Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated FILTER_SANITIZE_STRING #5555

Merged
merged 3 commits into from
Jan 8, 2022
Merged

fix: replace deprecated FILTER_SANITIZE_STRING #5555

merged 3 commits into from
Jan 8, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 8, 2022 •
edited
Loading

This PR goes into hotfix-4.1.7 .

Description
Supersedes #5540
Follow-up #5005

  • replace FILTER_SANITIZE_STRING with FILTER_SANITIZE_FULL_SPECIAL_CHARS in get_cookie()
  • add warning on get_cookie() xxsClean

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

TimZ99 and others added 3 commits January 8, 2022 10:03
@TimZ99 @kenjis
Replaced deprecated FILTER_SANITIZE_STRING
505b396 
Replaced with FILTER_SANITIZE_FULL_SPECIAL_CHARS. Equivalent to calling htmlspecialchars() with ENT_QUOTES set.
@TimZ99 @kenjis
Replaced deprecated FILTER_SANITIZE_STRING
490fece 
Replaced with FILTER_SANITIZE_FULL_SPECIAL_CHARS. Equivalent to calling htmlspecialchars() with ENT_QUOTES set.
@kenjis
docs: add changelogs, upgrade_417, and warning in cookie_helper.rst
b4b24e0
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them hotfix breaking change Pull requests that may break existing functionalities labels Jan 8, 2022
@kenjis kenjis merged commit 297c72d into codeigniter4:hotfix-4.1.7 Jan 8, 2022
@kenjis kenjis deleted the replace_deprecated_filter branch January 8, 2022 02:40
@kenjis kenjis mentioned this pull request Jan 8, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @TimZ99